Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-16475: add more tests to TopicImageNodeTest #15735

Merged
merged 2 commits into from
Apr 30, 2024
Merged

KAFKA-16475: add more tests to TopicImageNodeTest #15735

merged 2 commits into from
Apr 30, 2024

Conversation

mannoopj
Copy link
Contributor

add unit tests for add TopicImageNode

@chia7712
Copy link
Contributor

@mannoopj thanks for this patch. There is already a patch (#15720) to fix the same issue. It would be great if you can be a reviewer there.

@cmccabe
Copy link
Contributor

cmccabe commented Apr 16, 2024

Thanks, @mannoopj. Since this adds some new test cases beyond what was in #15720, can you rebase your PR on trunk?

@mannoopj mannoopj force-pushed the KAFKA-16475-TopicImageNode-unit-tests branch from 1afeb09 to 8f352ab Compare April 29, 2024 14:08
cmccabe
cmccabe approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@cmccabe cmccabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmccabe cmccabe changed the title KAFKA-16475 add TopicImageNodeTest KAFKA-16475: add more tests to TopicImageNodeTest Apr 30, 2024
@cmccabe cmccabe merged commit 31355ef into apache:trunk Apr 30, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmccabe cmccabe cmccabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mannoopj @chia7712 @cmccabe